LNURL-pay drain #674
Open
LNURL-pay drain #674
+232
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
force-pushed
the
savage-lnurl-drain
branch
from
a3145aa to
d0cd0da
Compare
dangeross
force-pushed
the
savage-lnurl-drain
branch
from
d0cd0da to
1f64171
Compare
| false => { | ||
| let prompt = format!( | ||
| "Amount to pay (min {} sat, max {} sat): ", | ||
| pd.min_sendable / 1000, |
There was a problem hiding this comment.
Wouldn't it be possible for the integer division by 1000 to result in a sat amount that is lower than the actual min?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559
Testing notes: