-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set absolute fees when signing transactions #682
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered for the refunds if we could use the Relative fee variant instead of calculating it ourselves. What do you think?
@hydra-yse Are there any pending items here or we can merge? |
@hydra-yse PR #688 switched to a fork of boltz client. I prepared a branch in my fork that takes my commit on top of trunk so that you can use it here. See |
I've tried using relative fees but I get min relay fee error (testnet):
Should probably ping Boltz about this, even though their tests seem to be passing. I've looked into it to see if something's off on our side, but nothing yet. |
af7f5d0
to
44e76a7
Compare
@hydra-yse Are we getting a different fee when we calculate it ourselves? because we are broadcasting using the same electrum server |
Yes, turns out there's a difference. Calculating with absolute ourselves returns 21 sats, meanwhile relative (with 0.1sat/vb) returns 17 sats (below min relay of 19 sats). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Lets stick to absolute and ping Boltz. I thought maybe its the dummy fee, but not sure
Reflect changes from SatoshiPortal/boltz-rust@db045fb