Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set absolute fees when signing transactions #682

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hydra-yse
Copy link
Member

Reflect changes from SatoshiPortal/boltz-rust@db045fb

Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered for the refunds if we could use the Relative fee variant instead of calculating it ourselves. What do you think?

@roeierez
Copy link
Member

@hydra-yse Are there any pending items here or we can merge?

@danielgranhao
Copy link
Contributor

@hydra-yse PR #688 switched to a fork of boltz client. I prepared a branch in my fork that takes my commit on top of trunk so that you can use it here. See 71ca24969c8e339a9d92d7e52ed17c61c4d11110.

@hydra-yse
Copy link
Member Author

hydra-yse commented Jan 26, 2025

@dangeross

I wondered for the refunds if we could use the Relative fee variant instead of calculating it ourselves. What do you think?

I've tried using relative fees but I get min relay fee error (testnet):

[2025-01-26 22:16:18.831 WARN breez_sdk_liquid::send_swap:145] Could not refund Send swap ... cooperatively: Generic { err: "Electrum server error: \"sendrawtransaction RPC error -26: min relay fee not met, 17 < 19\"" }

Should probably ping Boltz about this, even though their tests seem to be passing. I've looked into it to see if something's off on our side, but nothing yet.

@dangeross
Copy link
Collaborator

dangeross commented Jan 27, 2025

I've tried using relative fees but I get min relay fee error (testnet):

@hydra-yse Are we getting a different fee when we calculate it ourselves? because we are broadcasting using the same electrum server

@hydra-yse
Copy link
Member Author

hydra-yse commented Jan 27, 2025

I've tried using relative fees but I get min relay fee error (testnet):

@hydra-yse Are we getting a different fee when we calculate it ourselves? because we are broadcasting using the same electrum server

Yes, turns out there's a difference. Calculating with absolute ourselves returns 21 sats, meanwhile relative (with 0.1sat/vb) returns 17 sats (below min relay of 19 sats).

Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Lets stick to absolute and ping Boltz. I thought maybe its the dummy fee, but not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants