Improve how refundable items are displayed on payment list #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
get_refund_refundable_payment_item
branch
3 times, most recently
from
7c240fc to
65c7d65
Compare
Base automatically changed from
get_refund_acc_required_action
to
get_refund_refresh
January 23, 2025 12:53
erdemyerebasmaz
force-pushed
the
get_refund_refundable_payment_item
branch
2 times, most recently
from
66c7a67 to
5f51822
Compare
erdemyerebasmaz
force-pushed
the
get_refund_refundable_payment_item
branch
from
5f51822 to
7c7b80a
Compare
erdemyerebasmaz
changed the title
dangeross
approved these changes
Jan 27, 2025
danielgranhao
approved these changes
Jan 27, 2025
Testing Notes
Their amount & fees are shown as is & should reflect the original transaction. The refundable amount is only shown through CC: @Nackoo2000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
This PR is a continuation of #295, and applies the same style choice to payments in
Refundablestate, where applicable.Changes:
(Failed)suffix to subtitle of refundable items on payment listXicon as the payment avatar for refundable items on payment listFailedchip on payment details for refundable itemsAmount & Fees are shown as is.
Misc:
PaymentDetailsSheetRefundTxAmount