Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening of info window of marker #11

Merged
merged 1 commit into from
May 3, 2021

Conversation

rabauss
Copy link

@rabauss rabauss commented May 2, 2021

This is a hotfix for egeloen#279

The opening event of a info window of a marker needs the marker object! To prevent the adding of another event here:

$event->addCode($formatter->renderCode($this->infoWindowOpenRenderer->render($infoWindow, $map)));

the open property of infoWindow needs to be reseted after adding the new event for the info window of a marker!

@bresam bresam changed the base branch from master to tmp May 3, 2021 13:04
@bresam bresam merged commit 149535b into bresam:tmp May 3, 2021
@bresam
Copy link
Owner

bresam commented May 3, 2021

Thank you for your contribution 🎉

@rabauss rabauss deleted the hotfix/marker-infowindow branch May 4, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants