-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gleam_json
to 2.x
#5
Conversation
looking forward to this being merged |
It would be really useful to get this merged! |
@brettkolodny Have you had a chance to review this PR yet? Any changes you need? |
Sorry! Been a bit MIA since the holidays. Going to take a look now! |
@SnakeDoc All looks good! One thing though, should the |
@brettkolodny Great suggestion! I think I was just copying the existing range pattern, but you are right, it's best to be compatible with the entire 2.x range. Let me get that fixed up sometime tonight. I'll also re-update everything else while we have the hood open 🚀 |
@brettkolodny Added the following:
Builds with all tests passing locally - but this has a bit more surface area than before and probably warrants a closer look. Let me know what you think! |
Looks good to me, thank you! Will get this released now |
Thank you 👍 |
This PR closes #4
This PR is broken down into a few steps:
gleam_json
's range to2.x
along with it's locked version.gleam_stdlib
update.Let me know if I missed anything or you need something changed! 🚀