Handle .ndim and [:, np.newaxis] on VariableView #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used when handing a VariableView directly to matplotlib, e.g. for spike_mon.i (an expression like spike_mon.t/ms directly results in an ndarray and is therefore not concerned). This problem was introduced with matplotlib 3.5.2, previous versions converted VariableView along the way with a call to np.asanyarray. Fixes #1409
|
I am going ahead merging this, even though it is a bit of an ugly workaround, but I keep running into this issue when running Brian's development version. I opened #1422 to keep track of this issue. |
|
Can we have a patch release that includes the fix? |
|
I'm out of office until end of May, so I can't do it before then. Note that you can install the development package from TestPyPi though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used when handing a
VariableViewdirectly to matplotlib, e.g. forspike_mon.i(an expression likespike_mon.t/msdirectly results in anndarrayand is therefore not concerned). This problem was introduced with matplotlib 3.5.2, previous versions convertedVariableViewalong the way with a call tonp.asanyarray.The fix is a minimal workaround, but we have plenty of examples, including the tutorials, that will fail plotting, so fixing this is urgent. For a proper fix I'd like to think a bit more about how (and whether) to support features like adding array dimensions, in particular for synaptic variables which support a form of 2d-indexing which is not the same as for a 2d
ndarray.Fixes #1409