Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a tiny function to tack tiny UUID's to end of LocalStorage keys instead of a seperate indexer #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

forbesmyester
Copy link

Instead of using LocalStorage keys like "storeadaptorname.key" and a seperate indexer to maintain order I have used a key in the form "storeadaptorname.key.UUID" where UUID is a small creation time orderable string.

This removes the requirement for a separate indexer and therefore should make the storage more reliable as writes will be more atomic.

@forbesmyester
Copy link
Author

Could I get feedback on this I would love for it to get merged in, it took me a reasonable amount of time to pull this together. Right now I am looking for work also and this would be a big feather in my cap.

I am aware that this is a big change and it may be better for it to be a separate adaptor but am happy to work with you on any changes you think are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant