media: Do not attach volume when disabled #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the volume is attached as emptyDir, it will be a local volume resulting in inability to drain a node because of existing local volumes in the pod. This changes the semantics such that /media is never mounted as a volume if it is not specifically enabled, allowing jellyfin to be re-located to other nodes in the cluster
brianmcarey
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Hi @christf - thanks for the PR. It looks good.
As far as I can remember - the reason I went with the emptyDirwas so that users could easily test out their media by simply dropping it into the local volume. That will be difficult to do without it.
I am pretty sure you can still drain the node with something like:
kubectl drain <node> --delete-emptydir-data=true
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the volume is attached as emptyDir, it will be a local volume
resulting in inability to drain a node because of existing local volumes
in the pod. This changes the semantics such that /media is never mounted
as a volume if it is not specifically enabled, allowing jellyfin to be
re-located to other nodes in the cluster