Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat schema parameter as case sensitive #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

al3xandru
Copy link

Do all the necessary escaping internally so schema parameter can be treated as case sensitive

@brianmhess
Copy link
Owner

The current version does allow you to use case-sensitive keyspace, table, and column names. For example, you can do
-schema 'myks."MyTable"(col1, "Col2")'
Does that cover the use case you are looking to address?

@al3xandru
Copy link
Author

That gets unnecessarily cumbersome very fast.

@phact
Copy link
Contributor

phact commented Jul 1, 2016

The double quotes standard around upper case keyspaces and columns is a cassandra standard. You have to do it in cqlsh, at the driver, etc.

I see your point about it being a bit cumbersome however and am having trouble thinking of downsides of the change. What happens if there's a table called myTable and another table called mytable. Would this be able to tell the difference?

@brianmhess
Copy link
Owner

Based on this https://docs.datastax.com/en/cql/3.3/cql/cql_reference/ucase-lcase_r.html I think requiring double quotes to get case sensitivity is necessary (even if a bit cumbersome).

@phact
Copy link
Contributor

phact commented Aug 17, 2016

With JSON, this becomes a bigger issue because now we're requiring the column names to come escaped in the JSON file. Nobody will have this. I think it's time to re-evaluate

@phact
Copy link
Contributor

phact commented Aug 17, 2016

Here's a new PR to deal with the JSON issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants