Use current php version parser #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding this in the same file does not work for running the test suite in PHP7.4. I would need to extract it to either an own TestClass or include the definition of the array when the test is executed. |
|
I don't mind raising the minimum PHP requirement to 8.1 either. This is currently the oldest supported version, and most brick libraries already require PHP 8.1. |
|
should I do it in this pull request or in a separate one to keep them distinct? |
|
It would be nice to do it in another PR! |
reinfi
force-pushed
the
use-current-php-version-parser
branch
from
f00d71b to
f6084bf
Compare
|
Thank you, @reinfi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #37.
Hopefully the test is enough, without the change it fails locally. But then every test fails cause the PHPParser cannot parse the test file anymore.