Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hashicorp/setup-terraform from 2.0.3 to 3.0.0 #456

Bump hashicorp/setup-terraform from 2.0.3 to 3.0.0

75c0a29
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Bump hashicorp/setup-terraform from 2.0.3 to 3.0.0 #456

Bump hashicorp/setup-terraform from 2.0.3 to 3.0.0
75c0a29
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci-lint succeeded Jan 9, 2024 in 0s

reviewdog [golangci-lint] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (44)

src/common/yaml/yaml_writer.go|228 col 6| removeLineByAttribute is unused (deadcode)
src/common/color_check.go|12 col 20| captLocal: NoColorBool' should not be capitalized (gocritic) [src/common/utils/utils_test.go|112 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L112) commentFormatting: put a space between //and comment text (gocritic) [src/common/tagging/external/tag_group.go|79 col 4|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/tagging/external/tag_group.go#L79) typeSwitchVar: 1 case can benefit from type switch with assignment (gocritic) [src/common/json/json_writer.go|94 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/json/json_writer.go#L94) ifElseChain: rewrite if-else to switch statement (gocritic) [src/terraform/structure/terraform_parser.go|33 col 44|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/terraform/structure/terraform_parser.go#L33) commentFormatting: put a space between//and comment text (gocritic) [src/terraform/structure/terraform_parser.go|269 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/terraform/structure/terraform_parser.go#L269) commentFormatting: put a space between//and comment text (gocritic) [src/common/runner/runner.go|95 col 15|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/runner/runner.go#L95) appendAssign: append result not assigned to the same slice (gocritic) [src/common/color_check.go|4|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/color_check.go#L4) File is notgofmt-ed with -s(gofmt) [src/common/tagging/external/tag_group.go|244|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/tagging/external/tag_group.go#L244) File is notgofmt-ed with -s(gofmt) [tests/utils/utils.go|9|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/tests/utils/utils.go#L9) File is notgofmt-ed with -s(gofmt) [src/common/reports/report_service.go|152|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/reports/report_service.go#L152) File is notgofmt-ed with -s(gofmt) [src/common/reports/results_test.go|123|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/reports/results_test.go#L123) File is notgofmt-ed with -s(gofmt) [main.go|125|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/main.go#L125) File is notgofmt-ed with -s(gofmt) [src/common/color_check.go|34|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/color_check.go#L34) File is notgoimports-ed (goimports) [src/serverless/structure/serverless_parser.go|6|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/serverless/structure/serverless_parser.go#L6) File is not goimports-ed (goimports) [src/common/tagging/code2cloud/tag_group.go|4|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/tagging/code2cloud/tag_group.go#L4) File is not goimports-ed (goimports) [src/common/tagging/code2cloud/yor_name.go|4|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/tagging/code2cloud/yor_name.go#L4) File is not goimports-ed (goimports) [src/common/runner/runner_test.go|5|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/runner/runner_test.go#L5) File is not goimports-ed (goimports) [src/common/tagging/external/tag_group.go|223 col 14|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/tagging/external/tag_group.go#L223) should replace gitModifiersCounts[matchValue] += 1withgitModifiersCounts[matchValue]++(golint) [src/terraform/structure/terraform_block.go|69 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/terraform/structure/terraform_block.go#L69) varresourceIdshould beresourceID(golint) [src/common/runner/runner_test.go|299 col 5|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/runner/runner_test.go#L299) should replaceyorNameCounter += 1withyorNameCounter++(golint) [src/common/runner/runner_test.go|300 col 5|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/runner/runner_test.go#L300) varresourceIdPartsshould beresourceIDParts(golint) [src/common/reports/report_service.go|56 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/reports/report_service.go#L56) don't use underscores in Go names; varnew_countshould benewCount(golint) [src/common/reports/report_service.go|57 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/reports/report_service.go#L57) don't use underscores in Go names; varupdated_countshould beupdatedCount(golint) [src/common/utils/utils_test.go|206 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L206)elemsis unused (structcheck) [src/common/utils/utils_test.go|207 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L207)vSliceis unused (structcheck) [src/common/utils/utils_test.go|69 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L69)sliceis unused (structcheck) [src/common/utils/utils_test.go|70 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L70)elemis unused (structcheck) [src/common/utils/utils_test.go|210 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L210)nameis unused (structcheck) [src/common/utils/utils_test.go|211 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L211)argsis unused (structcheck) [src/common/utils/utils_test.go|212 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L212)wantis unused (structcheck) [src/common/utils/utils_test.go|73 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L73)nameis unused (structcheck) [src/common/utils/utils_test.go|74 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L74)argsis unused (structcheck) [src/common/utils/utils_test.go|75 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/utils/utils_test.go#L75)wantis unused (structcheck) [src/common/logger/logging_service.go|15 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/logger/logging_service.go#L15)tempWriteris unused (structcheck) [src/common/runner/runner.go|41 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/runner/runner.go#L41)localModuleTagis unused (structcheck) [src/common/yaml/yaml_writer.go|216 col 41|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/common/yaml/yaml_writer.go#L216)getYAMLLines-isCfnis unused (unparam) [src/terraform/structure/terraform_parser.go|569 col 3|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/terraform/structure/terraform_parser.go#L569) S1005: unnecessary assignment to the blank identifier (gosimple) [src/serverless/structure/serverless_parser.go|41 col 2|](https://github.com/bridgecrewio/yor/blob/75c0a291f3f95d40dfb3efad37ed3fccf06cec83/src/serverless/structure/serverless_parser.go#L41) S1023: redundantreturn` statement (gosimple)
src/cloudformation/structure/cloudformation_parser.go|198 col 3| ineffectual assignment to ok (ineffassign)
src/common/json/json_writer.go|157 col 5| ineffectual assignment to parentIdentifier (ineffassign)
src/common/runner/runner_test.go|288 col 3| ineffectual assignment to err (ineffassign)
src/common/yaml/yaml_writer.go|299 col 5| ineffectual assignment to readResources (ineffassign)