Skip Comment Feature #530
Merged
Skip Comment Feature #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
@ChanochShayner can you review it please? |
Thank you for your contribution! |
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
src/common/runner/runner.go
Outdated
| @@ -43,6 +43,8 @@ type Runner struct { | |||
|
|
|||
| const WorkersNumEnvKey = "YOR_WORKER_NUM" | |||
|
|
|||
| var mutex sync.Mutex | |||
There was a problem hiding this comment.
Please remove it if it is not in use.
| @@ -25,12 +25,13 @@ import ( | |||
| ) | |||
|
|
|||
| var ignoredDirs = []string{".git", ".DS_Store", ".idea", ".terraform"} | |||
| var mutex sync.Mutex | |||
There was a problem hiding this comment.
Please remove it if it is not in use.
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
achiar99
approved these changes
Jun 20, 2024
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
chanaMovshowich
temporarily deployed
to
scan-security
GitHub Actions
Inactive
|
@chanaMovshowich Please add # checkov:skip=CKV_SECRET_80 to src/terraform/structure/terraform_parser.go in line 363 (like line 361), it recognizes the line as a secret. |
chanaMovshowich
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature allows for adding special comments above resources that users wish to exclude from tagging, enabling skipping tagging for specific resources, the special comments are: "yor:skip" to skip a specific resource and "yor:skipAll" to skip all resources on the page.
It addresses the difficulties encountered in tagging resources within large and intricate projects, streamlining the process and reducing potential errors.
fixes: #531