fix gcp with perfix #548
Merged
fix gcp with perfix #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamKaufman
temporarily deployed
to
scan-security
GitHub Actions
Inactive
|
Looks good! |
ChanochShayner
approved these changes
Jul 16, 2024
lirshindalman
approved these changes
Jul 24, 2024
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description:
Yor already handles fixing of certain label values based on the GCP constraints. Like '/' gets converted to '__' for git_file label value. But if yor argument tag-prefix is specified, this handling does not work.
Solution description:
Checking whether there is a prefix in the tags and appropriate treatment
fixes:#444