assign undoManager.restore to avoid leaking EditorView

briefercloud · Oct 24, 2024 · 24037f8 · 24037f8
1 parent 7d08c3c
commit 24037f8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/apps/web/src/components/v2Editor/Title.tsx b/apps/web/src/components/v2Editor/Title.tsx
@@ -96,7 +96,11 @@ function Title(props: Props) {
       // manually destroy collaboration undo manager
       try {
         // @ts-ignore
-        editor?.state['y-undo$']?.undoManager?.destroy()
+        const undoManager = editor?.state['y-undo$']?.undoManager
+        if (undoManager) {
+          undoManager.destroy()
+          undoManager.restore = null
+        }
       } catch (e) {
         console.error('Failed to destroy collaboration undo manager', e)
       }

diff --git a/apps/web/src/components/v2Editor/customBlocks/richText/index.tsx b/apps/web/src/components/v2Editor/customBlocks/richText/index.tsx
@@ -112,7 +112,11 @@ const useBlockEditor = ({
       // manually destroy collaboration undo manager
       try {
         // @ts-ignore
-        editor?.state['y-undo$']?.undoManager?.destroy()
+        const undoManager = editor?.state['y-undo$']?.undoManager
+        if (undoManager) {
+          undoManager.destroy()
+          undoManager.restore = null
+        }
       } catch (e) {
         console.error('Failed to destroy collaboration undo manager', e)
       }