Fix drag preview #304
Merged
Fix drag preview #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
reviewed
Dec 29, 2024
| import { CSSProperties, useEffect } from 'react' | ||
| import { useDragLayer, XYCoord } from 'react-dnd' | ||
| import IconSelector from './IconSelector' | ||
| import { ElementType } from './v2Editor' |
There was a problem hiding this comment.
I think this is what's causing the ssr error by the way.
When you import ./v2Editor you end up importing ./customBlocks/python which imports ./PythonOutput.
Rule of thumb is, do not import stuff from v2Editor with ssr, a lot of stuff from that folder do not work with ssr.
We should probably just move ElementType to it's own file, maybe we can introduce a utils/dragndrop.ts file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the drag preview for the editor and also adds "scroll on drag".
PS: I also updated the plotly import because I was having issues with it rendering on the server side.
See plotly/react-plotly.js#272
Not sure why this started happening now though