Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factoids Rewrite #36

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
15321a5
style(require): use .persistent. for more clear naming
brigand Oct 5, 2019
8e2b5a3
chore: update factoids
brigand Oct 6, 2019
64b095d
chore: factoid scripts and remove toml
brigand Oct 6, 2019
4029374
feat(factoids): reimplement factoids and adds !learn
brigand Oct 6, 2019
ab311ba
chore(factoids): cleanup
brigand Oct 6, 2019
ab38c84
chore(factoids): cleanup
brigand Oct 6, 2019
2bb0a4b
chore(lint): resolves all lint errors
brigand Oct 6, 2019
6b80b03
build(actions): run lint in pr action
brigand Oct 6, 2019
e8d15af
ci: switch to npm, use node 12.x
brigand Oct 6, 2019
7ee1e7e
feat(factoids): wip trying to use private fields
brigand Oct 6, 2019
8222499
fix(factoids): use class fields properly
brigand Oct 6, 2019
3e38084
enhance(factoids): use slugify for channel file name
brigand Oct 6, 2019
b2f2cb0
feat: adds validation for non-diacritic text
brigand Oct 6, 2019
87fd692
chore: updates all deps
brigand Oct 6, 2019
24186b6
fix(factoids): minor fixes
brigand Oct 6, 2019
0ea66fa
updated factoids
brigand Oct 7, 2019
fccfbb2
feat(factoids): simplify the factoids data structure
brigand Oct 7, 2019
8247cfb
refactor(factoids): separate parsing and behavior
brigand Oct 7, 2019
f5deeae
feat: better error handling/reporting
brigand Oct 7, 2019
8caaba9
enhance(factoids): improved messages and bug fixes
brigand Oct 7, 2019
07cf070
feat(factoids): !publish <key>
brigand Oct 7, 2019
631920a
fix(factoids): minor fixes
brigand Oct 7, 2019
58e794d
chore: lint
brigand Oct 7, 2019
4975a94
fix(factoids): misc fixes
brigand Oct 7, 2019
00cfff5
chore(factoids): updates data file
brigand Oct 7, 2019
a097c31
updated factoids
brigand Oct 10, 2019
7a12579
feat(factoids): !learn always requires a separate !publish, and related
brigand Oct 13, 2019
c98043a
updated factoids
brigand Oct 13, 2019
0b57a42
fix(factoids): use default name for very old factoids
brigand Oct 13, 2019
0c07b50
test(jseval): increase timeout for OSX hosts
brigand Oct 22, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
src/plugins/js-eval/vendor/engine262.js
scripts/sshUtils.js
1 change: 1 addition & 0 deletions .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ rules:
no-nested-ternary: 0
no-confusing-arrow: 0
consistent-return: 0
no-else-return: 0
no-console:
- 2
- allow: ['debug', 'warn', 'error', 'log']
Expand Down
30 changes: 13 additions & 17 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -1,25 +1,21 @@
name: Node CI

on: [push, pull_request]
on: [pull_request]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [10.x, 12.x]

steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: npm install and test
run: |
npm install
npm test
env:
CI: true
- uses: actions/checkout@v1
- name: Use Node.js 12.x
uses: actions/setup-node@v1
with:
node-version: 12.x
- name: npm install and test
run: |
npm install
npm run lint
npm test
env:
CI: true
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ coverage
scripts/env.sh
jellobot-config.*
*.tgz
.vscode

1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
12
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ To full run the bot, you'll need node.js (10.x recommended), docker (with your u
having permission to execute containers), and libmagic.

```sh
# Install libmagic on OSX
brew install libmagic
# Install libmagic and icu4c on OSX
brew install libmagic icu4c
```

Then to get the dependencies run `npm install`.
Expand Down
Loading