fixing unit tests

brightdigit · May 6, 2024 · 087a3b5 · 087a3b5
1 parent 819baa1
commit 087a3b5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Sources/AviaryInsights/Event.swift b/Sources/AviaryInsights/Event.swift
@@ -28,6 +28,7 @@
 //
 
 public struct Event {
+  public static let pageview = "pageview"
   public let name: String
   public let domain: String?
   public let url: String
@@ -36,8 +37,8 @@ public struct Event {
   public let revenue: Revenue?
 
   public init(
-    name: String,
     url: String,
+    name: String = Self.pageview,
     domain: String? = nil,
     referrer: String? = nil,
     props: [String: (any Sendable)?]? = nil,

diff --git a/Tests/AviaryInsightsTests/AviaryInsightsTests.swift b/Tests/AviaryInsightsTests/AviaryInsightsTests.swift
@@ -73,7 +73,7 @@ final class AviaryInsightsTests: XCTestCase {
   func randomProps() -> [String: (any Sendable)?] {
     var values = [String: (any Sendable)?]()
     let keyCount: Int = .random(in: 3 ... 7)
-    for index in 0 ..< keyCount {
+    for _ in 0 ..< keyCount {
       let value: any Sendable
       let type: Bool = .random()
       switch type {
@@ -98,9 +98,9 @@ final class AviaryInsightsTests: XCTestCase {
       let count: Int = .random(in: 10 ... 20)
       return (0 ..< count).map { _ in
         Event(
+          url: UUID().uuidString,
           name: UUID().uuidString,
           domain: Bool.random() ? UUID().uuidString : nil,
-          url: UUID().uuidString,
           referrer: Bool.random() ? UUID().uuidString : nil,
           props: Bool.random() ? randomProps() : nil,
           revenue: Bool.random() ? .random() : nil