Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch toluapp for reproducible output #1619

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

bmwiedemann
Copy link

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • Documentation in doc/ has been updated
  • All new code is licensed under GPLv3

Description

  • Describe the changes, why they were necessary, etc
    • Without this patch, the generated libimlib2.c and libcairo.so varied every time.
  • Describe how the changes will affect existing behaviour.
    • It should behave the same as before
  • Describe how you tested and validated your changes.
    • I tested that it builds, but not if it works.
  • Include any relevant screenshots/evidence demonstrating that the changes work and have been tested.
    • NA

This PR was done while working on reproducible builds for openSUSE.

Without this patch, libimlib2.c varied every time.

This patch was done while working on reproducible builds for openSUSE.
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 71044bc
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/64fab7bddc8ec00008e45896

@github-actions github-actions bot added the 3rdparty Issue or PR that suggests changes to 3rd party dependencies label Sep 8, 2023
@bmwiedemann
Copy link
Author

Unfortuately, https://github.com/LuaDist/toluapp is read-only, so I could not contribute these patches there. If you use a different upsteam, feel free to push patches there.

@brndnmtthws
Copy link
Owner

Sweet, thanks!

@brndnmtthws brndnmtthws merged commit 68ac284 into brndnmtthws:main Sep 8, 2023
53 checks passed
@bmwiedemann bmwiedemann deleted the reproducible branch September 9, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rdparty Issue or PR that suggests changes to 3rd party dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants