Use perfect hash (gperf) for parsing color names #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
the
gh-actions
Caellian
commented
Apr 20, 2024
Comment on lines
-53
to
-56
| #ifdef BUILD_X11 | ||
| unsigned long Colour::to_x11_color(Display *display, int screen, | ||
| bool transparency, bool premultiply) { |
There was a problem hiding this comment.
Moved to x11-color.cc where previous matching function was.
Caellian
force-pushed
the
dev/cleanup-globals
branch
2 times, most recently
from
9a2ec7a
to
c69dcaf
Compare
brndnmtthws
approved these changes
Apr 20, 2024
Caellian
force-pushed
the
dev/cleanup-globals
branch
3 times, most recently
from
cba15e6
to
8e07629
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/color-perf-hash
branch
from
9f71a4a
to
f34b5dd
Compare
✅ Deploy Preview for conkyweb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
build system
Caellian
force-pushed
the
dev/color-perf-hash
branch
from
e629fc3
to
e4d4e9b
Compare
Made CMake copy the file renamed in case gperf isn't available. This should prevent the compiler from finding stub before generated file. Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/color-perf-hash
branch
from
e4d4e9b
to
5133193
Compare
Signed-off-by: Tin Švagelj <[email protected]>
github-actions
bot
added
the
documentation
|
This commit sounds good (so, thank you!) but just what does it mean for the writer of conkies? How should we give colour names now? Is the new system backwards compatible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces X11 color name lookup with something that's easier to maintain.
Performance
Possibly faster than previous implementation - previous used binary search (
O(log n)) on sorted color names, new uses a perfect hash (O(1)).Extensibility
The main selling point of this PR is that it replaces code that was hard to extend with something where people can easily add their own colors.
While writing this PR, I realized that the previous could could've just been simplified to achieve same extensibility, but I guess perf. hash scales better and doesn't require colors to be sorted in advance (though that can be automated).
Testing
Tested by preexisting tests.