Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web components and pages (UI) #1853

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

farishan
Copy link
Contributor

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • Documentation in doc/ has been updated
  • All new code is licensed under GPLv3

Description

  • Describe the changes, why they were necessary, etc
    Enhancing web UI responsiveness, readability and usability, as I try to leave the code better than I found it.
  • Fix overflow on small viewport
  • Fix pages & components spacing, mostly padding & consistency issues
  • Change date on footer for better human readability
  • Change nav items position to prevent header overflow on screens smaller than 480px
  • Describe how the changes will affect existing behaviour.
    No Conky core code modified, so it should not affect existing behaviour.

  • Describe how you tested and validated your changes.
    Linted and headless E2E tested.

  • Include any relevant screenshots/evidence demonstrating that the changes work and have been tested.
    To see and feel the enhanced UI, I suggest to run the web locally and compare with current live site as the changes are many but tiny.

More:
I don't understand how to license my changes, but I allowed the Conky community to use it (or not) however they want.
Build and checks passed.
If this PR merged, should there any issues in the future related to the modified web components and pages, please contact me and I will take the responsibility to fix the issues.

@github-actions github-actions bot added the web Issue or PR related to documentation website label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for conkyweb ready!

Name Link
🔨 Latest commit 965c4c5
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6626103d035b420008c4e7e7
😎 Deploy Preview https://deploy-preview-1853--conkyweb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brndnmtthws brndnmtthws merged commit c51fbe6 into brndnmtthws:main Apr 22, 2024
11 checks passed
Copy link
Collaborator

@Caellian Caellian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how to license my changes, but I allowed the Conky community to use it (or not) however they want.
Build and checks passed.
If this PR merged, should there any issues in the future related to the modified web components and pages, please contact me and I will take the responsibility to fix the issues.

See licensing section of contributing guide. You're under no legal obligation to fix things and it's completely up to your good will to do so if issues arise. Approval process is there to catch/correct mistakes, but everyone can write buggy code sometimes and your changes can easily be reversed if they end up causing more trouble than they're worth.

That being said, I reviewed your changes and they seem good. I hadn't checked responsiveness before, but I can only see one tiny layout quirk now and it's not related to any lines you've changed.

@farishan
Copy link
Contributor Author

@Caellian thanks for the info and review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Issue or PR related to documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants