Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement -U for Haiku. #2079

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

g0mb4
Copy link
Contributor

@g0mb4 g0mb4 commented Nov 14, 2024

Waiting for #2080.

Compiled with cmake -DBUILD_X11=FALSE ..

Tested on Haiku-r1beta5.
Takes part of #2072.

@github-actions github-actions bot added documentation Issue or PR that suggests documentation improvements sources PR modifies project sources labels Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 637ad69
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6738ac8ea69563000829bd7e

This patch also fixes a compilation error on Haiku.

Compiled with `cmake -DBUILD_X11=FALSE ..`

Tested on Haiku-r1beta5.
Takes part of brndnmtthws#2072.
@Caellian
Copy link
Collaborator

Changes to common.cc are already part of #2080. Let's get that one finished and merged first. Alternatively, given that Haiku doesn't compile at the moment (yes?), you can remove changes to common.cc to avoid difficulties with rebasing that one (given that it's larger).

@g0mb4
Copy link
Contributor Author

g0mb4 commented Nov 16, 2024

Sure, I'll revert common.cc.

A cross-platform solution is already implemented in brndnmtthws#2080.
This PR will be rebased *after* the OpenBSD fix was merged.
@g0mb4 g0mb4 changed the title Implement -U for Haiku. [WIP] Implement -U for Haiku. Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue or PR that suggests documentation improvements sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants