Skip to content

Commit

Permalink
add back 8.0
Browse files Browse the repository at this point in the history
  • Loading branch information
lucymcnatt committed Feb 12, 2025
1 parent a06a102 commit 378f32e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,15 @@ jobs:
matrix:
# Batch test fixes to land later
include:
- build_type: centaurPapiV2beta
build_mysql: 8.0
friendly_name: Life Sciences, MySQL 8.0
- build_type: centaurPapiV2beta
build_mysql: 8.4
friendly_name: Life Sciences, MySQL 8.4 (current Terra production)
- build_type: centaurGcpBatch
build_mysql: 8.0
friendly_name: GCP Batch, MySQL 8.0
- build_type: centaurGcpBatch
build_mysql: 8.4
friendly_name: GCP Batch, MySQL 8.4
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

## 88 Release Notes

### Mysql 8.4
### Mysql 8 & 8.4

Cromwell now supports MySQL 8.4 and 8.4-compatible databases. Older versions of MySQL are no longer officially supported or tested, but they are not explicitly forbidden from use.
Cromwell now supports MySQL 8.0 and 8.4 and 8.0 and 8.4-compatible databases. Older versions of MySQL are no longer officially supported or tested, but they are not explicitly forbidden from use.

### New feature: Prevent Job start during Cloud Quota exhaustion

Expand Down
2 changes: 2 additions & 0 deletions cromwell.example.backends/GCPBATCH.conf
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ backend {
# Batch Jobs and manipulate auth JSONs.
auth = "application-default"

logs-policy = "PATH"


// alternative service account to use on the launched compute instance
// NOTE: If combined with service account authorization, both that service account and this service account
Expand Down
2 changes: 1 addition & 1 deletion src/ci/bin/test_papi.inc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ cromwell::private::papi::setup_papi_gcloud() {
cromwell::build::add_exit_function cromwell::private::papi::teardown_papi_gcloud

gcloud auth activate-service-account --key-file="${CROMWELL_BUILD_PAPI_AUTH_JSON}"
export GOOGLE_APPLICATION_CREDENTIALS="${CROMWELL_BUILD_BATCH_AUTH_JSON}"
export GOOGLE_APPLICATION_CREDENTIALS="${CROMWELL_BUILD_PAPI_AUTH_JSON}"
gcloud config set account "${CROMWELL_BUILD_PAPI_CLIENT_EMAIL}"
gcloud config set project "${CROMWELL_BUILD_PAPI_PROJECT_ID}"
}
Expand Down

0 comments on commit 378f32e

Please sign in to comment.