[AN-286] Fixes deadlock issue in GROUP_METRICS_ENTRY table #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aednichols
approved these changes
Jan 14, 2025
Comment on lines
+49
to
+51
| if ex.isInstanceOf[SQLIntegrityConstraintViolationException] || (ex | ||
| .isInstanceOf[PSQLException] && ex.getMessage.contains( | ||
| "duplicate key value violates unique constraint \"UC_GROUP_METRICS_ENTRY_GI\"" |
There was a problem hiding this comment.
These are different cases for various DBs? I assume PSQL... is Postgres.
There was a problem hiding this comment.
Yes that is correct. Postgres throws general PSQLException when duplicate values are inserted and hence I added the text checking as well here.
LizBaldo
approved these changes
Jan 14, 2025
| } | ||
|
|
||
| /* | ||
| The approach here is to try and insert the record into the table and if that fails because a record with that |
There was a problem hiding this comment.
Crystal clear explanation, thanks a lot for adding that 😻
| } yield () | ||
| runTransaction(action) | ||
|
|
||
| runTransaction(insertAction, TransactionIsolation.ReadCommitted) |
There was a problem hiding this comment.
Do you want to add the link to the doc stating that postgress recommends ReaCommitted?
| @@ -109,6 +109,34 @@ class GroupMetricsSlickDatabaseSpec extends AnyFlatSpec with Matchers with Scala | |||
| } yield ()).futureValue | |||
| } | |||
|
|
|||
| it should "handle parallel upserts to database" taggedAs DbmsTest in { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the deadlock issue in GROUP_METRICS_ENTRY table.
Jira ticket: https://broadworkbench.atlassian.net/browse/AN-286
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes