Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.88.0 #2188

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Release 1.88.0 #2188

merged 4 commits into from
Jan 15, 2025

Conversation

eweitz
Copy link
Member

@eweitz eweitz commented Jan 14, 2025

No description provided.

dependabot bot and others added 4 commits December 15, 2024 06:39
@dependabot
Bump nanoid from 3.3.7 to 3.3.8
c29f6de 
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@bistline
Updating build script to use Google Artifact Registry
e5e7ae6
@bistline
Merge pull request #2187 from broadinstitute/jb-artifact-registry-switch
3b983f8 
Updating build script to use Google Artifact Registry (SCP-5153)
@eweitz
Merge pull request #2183 from broadinstitute/dependabot/npm_and_yarn/…
6aa7807 
…nanoid-3.3.8

Bump nanoid from 3.3.7 to 3.3.8
@eweitz eweitz requested review from bistline and jlchang January 14, 2025 18:59
@bistline bistline added the build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem. label Jan 15, 2025
@eweitz
Copy link
Member Author

eweitz commented Jan 15, 2025

The build failure is a false positive that we've seen before.

Total elapsed time: 27 minutes, 52 seconds

### FAILURES and ERRORS ###
*** Yarn test failures ***

*** Rails test failures ***

  FireCloudClientTest#test_get_methods:
  RuntimeError: Wrapped undumpable exception for: RestClient::NotAcceptable: 406 Not Acceptable
Exiting with code: 1
Error: Process completed with exit code 1.

@eweitz eweitz merged commit 8a2666c into main Jan 15, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bistline bistline bistline approved these changes

@jlchang jlchang jlchang approved these changes

Assignees
No one assigned
Labels
build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eweitz @bistline @jlchang