Merge pull request #28 from broadinstitute/dp-gatk-fix

bugfix version fetching for gatk and samtools
broadinstitute · Jun 11, 2020 · 64c4006 · 64c4006
2 parents fd383b2 + 03ae651
commit 64c4006
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tools/gatk.py b/tools/gatk.py
@@ -74,7 +74,7 @@ def version(self):
         return self.tool_version
 
     def _get_tool_version(self):
-        return subprocess.check_output([self.install_and_get_path(), '--version']).decode('UTF-8').strip()
+        self.tool_version = subprocess.check_output([self.install_and_get_path(), '--version']).decode('UTF-8').strip()
 
     def ug(self, inBam, refFasta, outVcf, options=None, JVMmemory=None, threads=None):
         options = options or ["--min_base_quality_score", 15, "-ploidy", 4]

diff --git a/tools/samtools.py b/tools/samtools.py
@@ -49,7 +49,7 @@ def version(self):
         return self.tool_version
 
     def _get_tool_version(self):
-        return subprocess.check_output([self.install_and_get_path(), '--version']).decode('UTF-8').split('\n')[0].split()[1]
+        self.tool_version = subprocess.check_output([self.install_and_get_path(), '--version']).decode('UTF-8').split('\n')[0].split()[1]
 
     def execute(self, command, args, stdout=None, stderr=None, background=False):    # pylint: disable=W0221
         tool_cmd = [self.install_and_get_path(), command] + args