Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use react-native-init-func to generate example app #421

Merged
merged 14 commits into from
Mar 11, 2021
Merged

feat: use react-native-init-func to generate example app #421

merged 14 commits into from
Mar 11, 2021

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented Feb 19, 2021 •
edited
Loading

UPDATED

BREAKING CHANGE: this may change the way that the React Native template version is used to generate the example app.

(alternative to PR #420)

for release 0.20.0 (issue #409)

TODO items:

  • rebase to get cleaner commit message items before merging
  • test with react-native-tvos
  • test with example react-native versions 0.62, 0.61, 0.60
  • test with example react-native version 0.64 (rc) - tested on Android only, encountered some issues on iOS for further investigation
  • test with view module
  • test with DEPRECATED --example-file-linkage option
  • test with --use-apple-networking option (seems to report a JSON error from NSCocoaErrorDomain if I try with Flipper removed - see issue --use-apple-networking issue in generated example #426)
  • update help text for example React Native template version
  • update option text in README.md
  • update other documentation in README.md
  • update help text (again) to be consistent with README.md
  • rebase (again) to further clean up the commit message items

Followup item(s) for another PR:

  • rename example react-native template option

resolves #312
closes #204

@brodycj brodycj self-assigned this Feb 19, 2021
@brodycj brodycj changed the title [WIP] refactor: use react-native-init-func to generate example app - DRAFT WIP refactor: use react-native-init-func to generate example app Feb 22, 2021
@brodycj brodycj force-pushed the use-react-native-init-func-to-generate-example-app branch from 477b816 to f5acbe9 Compare February 22, 2021 19:36
@brodycj brodycj mentioned this pull request Feb 23, 2021
Open
brodycj
brodycj commented Feb 23, 2021
View reviewed changes
lib/lib.js Outdated Show resolved Hide resolved
brodycj
brodycj commented Feb 23, 2021
View reviewed changes
lib/cli-command.js Outdated Show resolved Hide resolved
brodycj
brodycj commented Feb 24, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
brodycj
brodycj commented Feb 24, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
This was referenced Feb 24, 2021
Open
Merged
Open
@brodycj brodycj changed the title refactor: use react-native-init-func to generate example app [WIP] feat: use react-native-init-func to generate example app - DRAFT WIP Mar 11, 2021
@brodycj
chore: add react-native-init-func to package dependencies
897cb5f
@brodycj
refactor(prep): resolve *absolute* paths before generating example
785615c
@brodycj
test: replace absolute process cwd in output paths before taking snap…
410a99f 
…shots
@brodycj
feat: use react-native-init-func to generate example app
d4bc5c3 
BREAKING CHANGE: this may change how the React Native template version
is used to generate the example app.
@brodycj
refactor: make reactNativeInit overridable (for testing purposes)
4b2f4b5
@brodycj
test: update tests to use injected / mocked reactNativeInit function
23b2ee5
@brodycj
test: remove test for react-native CLI tool no longer needed
fcc1478
@brodycj
test: remove test of missing react-native CLI (no longer relevant)
5c79874
@brodycj
test: update test of missing Yarn CLI
5583273
@brodycj
refactor: update help text for --example-react-native-version
5b03ca6
@brodycj
refactor: update help text for --generate-example
a255c04
@brodycj
test: update test snapshots
d407f04
@brodycj
doc: update option text in README.md
b84399e
@brodycj
doc: update some more documentation in README.md
34e3c7a
@brodycj brodycj force-pushed the use-react-native-init-func-to-generate-example-app branch from b8bf695 to 34e3c7a Compare March 11, 2021 18:34
@brodycj brodycj changed the title [WIP] feat: use react-native-init-func to generate example app - DRAFT WIP feat: use react-native-init-func to generate example app Mar 11, 2021
@brodycj brodycj marked this pull request as ready for review March 11, 2021 19:01
@brodycj brodycj merged commit 56e7dbf into master Mar 11, 2021
@brodycj brodycj deleted the use-react-native-init-func-to-generate-example-app branch March 11, 2021 19:04
brodycj added a commit that referenced this pull request Mar 17, 2021
@brodycj
followup: update react-native-init-func -> ^0.0.4
eec3c84 
which uses @react-native-community/[email protected]

in followup to introduction of react-native-init-func
in 56e7dbf (PR #421)

this update should result in a smaller installation size
due to its use of prompts instead of inquirer

and should resolve a couple of Yarn audit messages
This was referenced Apr 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brodycj brodycj

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brodycj