Fixes #337 : multiple fixes in the code and modernize the style #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharcoux
force-pushed
the
refactor-and-fixes
branch
from
969169d
to
6f94dd7
Compare
added 6 commits
September 10, 2024 13:22
run `npx vite` into www folder to not need rebundle for now
|
I need to make some fixes first. Don't merge anything yet. I'll comment all the changes to justify them |
|
Will do, thank you |
This code is not working and does not seem to be related to webgazer as is now. Contains executable code for a server in python to collect training data and store in a sqlite db file (?)
|
I commented the changes, but I would still like to go a bit further with the www folder. I will see if I have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not 100% complete, as I don't understand very well the build process. I'd need some enlightenment about the www part in order to finish this MR. However, it solves numerous issues reported here along with other ones I noticed on the fly.