Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check permissions before page edits #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check permissions before page edits #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/controllers/cms/pages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,22 @@ def destroy
define_method status do
if params[:page_ids]
@pages = params[:page_ids].map { |id| Page.find(id) }
raise Cms::Errors::AccessDenied unless @pages.all? { |page| current_user.able_to_edit?(page) }
if status == :publish
raise Cms::Errors::AccessDenied unless @pages.all? { |page| current_user.able_to_publish?(page) }
else
raise Cms::Errors::AccessDenied unless @pages.all? { |page| current_user.able_to_edit?(page) }
end
@pages.each { |page| page.send(status) }
flash[:notice] = "#{params[:page_ids].size} pages #{verb}"
redirect_to dashboard_url
else
load_page
if status == :publish
raise Cms::Errors::AccessDenied unless current_user.able_to_publish?(@page)
else
raise Cms::Errors::AccessDenied unless current_user.able_to_edit?(@page)
end

if @page.send(status)
flash[:notice] = "Page '#{@page.name}' was #{verb}"
end
Expand Down Expand Up @@ -148,4 +158,4 @@ def load_templates
end

end
end
end