Bun support for update-browserslist-db #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Jul 1, 2024
ai
reviewed
Jul 1, 2024
|
You need instal bun to CI |
pornoiya
commented
Jul 1, 2024
test/index.test.js
Outdated
|
|
||
| let lock = (await readFile(join(dir, 'bun.lockb'))).toString() | ||
| ok( | ||
| lock.includes(`/caniuse-lite-${caniuse.version}`)) |
There was a problem hiding this comment.
Not sure if this check is OK. Maybe it's better to generate yarn.lock file and check versions in a more readable way. https://bun.sh/docs/install/lockfile
added 2 commits
July 1, 2024 17:21
ai
reviewed
Jul 1, 2024
| @@ -36,6 +36,7 @@ | |||
| "test": "pnpm run /^test:/" | |||
| }, | |||
| "dependencies": { | |||
| "bun": "^1.1.17", | |||
There was a problem hiding this comment.
No-no, it will install bun to every Browserslist users.
At least put it to devDependencies.
|
Do you have Twitter account to mention you in release tweet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.