Fixes for installing and building from the master branch #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts that need to be built can now specify a list of fragments to be included in addition to warn-auto.sh by listing the desired fragments in the associated =s file. Configuration files can be built into scripts assigning the configuration value to a shell variable, via build/auto-sh-str.sh. This is very similar to they way build/auto-str generates assignments of configuration values to C variables. Thus the build can generate lib/auto_bin.sh setting EZPATH based on conf-bin and lib/auto_qmail.sh setting QMPATH based on conf-qmail. By combining the two functions above, the build can now properly add a line setting EZPATH in ezmlm-accept, ezmlm-check, and ezmlm-glconf. It can also add a line setting QMPATH in ezmlm-check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was preparing a build with my changes in pull request #20 I observed (and then promptly forgot) that there were a few issues running
make install. I was reminded of the problems early this year, as I was working to get various email-related things in better shape given the Google sender requirements going into effect.The main problems were:
MANwere not reflecting the source's reorganization into subdirectoriesI also fixed a couple other things that weren't quite right:
ezmlm-dispatchwasn't installedEZPATHandQMPATHvariables weren't being added to shell scripts that needed themAnd because I wanted it (and it's generally useful for packaging purposes), I added support for specifying a
DESTDIRvariable that can be used to override the install root.