Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for zipped sdists and pinned url dependencies #202

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

bruno-fs
Copy link
Owner

@bruno-fs bruno-fs commented Sep 3, 2024

Modified pybuild-deps internals to rely more on pip internals, which gave us both support for url dependencies and zip archived packages for "free". This should fix (or at least cover most of) issues #188 and #187.

@bruno-fs bruno-fs force-pushed the issue/188-support-pinned-url-dependencies branch from fde74b0 to 9681736 Compare September 3, 2024 21:41
Modified pybuild-deps internals to rely more on pip internals, which
gave us both support for url dependencies and zip archived packages
for "free". This should fix (or at least cover most of) issues #188
and #187.

We will need to watch closely when pip releases new versions in order
fix breaking changes in its internal APIs.
@bruno-fs bruno-fs force-pushed the issue/188-support-pinned-url-dependencies branch from 9681736 to d94d295 Compare September 3, 2024 22:22
@brunoapimentel
Copy link
Collaborator

brunoapimentel commented Sep 5, 2024

I believe this solves #188, but not #187. I still get a tarball.ReadError if I try to process azure-core.

Otherwise, LGTM 🚀

@bruno-fs
Copy link
Owner Author

bruno-fs commented Sep 5, 2024

Thanks for verifying, @brunoapimentel. Would you mind zapping the (undocumented) cache dir (~/.cache/pybuild-deps) and trying again with with azure-core?

If this fixes it, we might need to think of a policy for handling broken things that were cached 🤔.
Maybe automatically clean it up if an error is found?

@brunoapimentel
Copy link
Collaborator

Thanks for verifying, @brunoapimentel. Would you mind zapping the (undocumented) cache dir (~/.cache/pybuild-deps) and trying again with with azure-core?

Yup, that does it!

If this fixes it, we might need to think of a policy for handling broken things that were cached 🤔. Maybe automatically clean it up if an error is found?

I think we can just document it initially. Maybe wipe the cache when a new version is installed? In any case, we can probably live with this for now.

@bruno-fs bruno-fs merged commit 2b39651 into main Sep 7, 2024
12 checks passed
@bruno-fs bruno-fs deleted the issue/188-support-pinned-url-dependencies branch September 7, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants