resteasy reactive in legumes #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobat
force-pushed
the
reactive-libs
branch
from
d2bfee0
to
3964f21
Compare
alesj
reviewed
Oct 12, 2023
| public void remove(final LegumeItem legume) { | ||
| manager.remove(legume); | ||
| public void removeLegume(final String legumeId) { | ||
| find("SELECT h FROM Legume h WHERE h.id=?1", legumeId).firstResult().onItem().transform(legume -> { |
There was a problem hiding this comment.
Does it have to be select?
Can't you just do "delete from x where x.id = ?!"?
alesj
reviewed
Oct 12, 2023
| @@ -33,68 +33,84 @@ public class LegumeResource implements LegumeApi { | |||
| @Inject | |||
| MessageSender messageSender; | |||
|
|
|||
| @Transactional | |||
| public Response provision() { | |||
| @WithTransaction | |||
There was a problem hiding this comment.
Reactive code requires a different annotation. I got a warning message.
alesj
reviewed
Oct 12, 2023
| quarkus.datasource.username: sa | ||
| quarkus.datasource.password: | ||
| quarkus.datasource.jdbc.max-size: 20 | ||
| #quarkus.datasource.db-kind=h2 |
There was a problem hiding this comment.
there is no reactive driver support for H2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform the Legumes service from imperative to reactive stack... Not really sure what to do with the artemis client.