Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LoadbalancerClass (1.22) #62

Closed
wants to merge 3 commits into from
Closed

Conversation

CodeStaple
Copy link
Contributor

As part part of the service spec, if the user sets service.loadbalancerClass it will add loadbalancerClass to the spec of the service and add the value from the charts values.

This configuration option comes in when you have a cluster with multiple Loadbalancer Controllers. For example MetalLB and ELB.

All cloudprovider controllers integrate with this service today.

@bryopsida
Copy link
Owner

@CodeStaple please bump the minor version, you'll need to run helm-docs to update the README.md as well. You can use make docs-update to run the helm-docs.

@CodeStaple
Copy link
Contributor Author

Hey! @bryopsida I'll sort this later today. Thanks 🙏

@CodeStaple
Copy link
Contributor Author

minor versions bumped and make command used to added new value into the README.md

Hopefully its all good from here 👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a badge with the version in the README.md, you can automatically update it if you run make docs-update. If you prefer to manually update it looks like it's just missing the change from 0.26.0 -> 0.27.0

@bryopsida
Copy link
Owner

Closing this, cherry picked the commit and integrating with #67

@bryopsida bryopsida closed this Jan 18, 2025
bryopsida added a commit that referenced this pull request Jan 18, 2025
Adds the ability to specify a load balancer class:
https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-class

Using the value `service.loadBalancerClass`, default is an empty string,
if an empty string the value will not be set retaining compatibility
with older but still tested kubernetes versions in the pipeline (1.23).

This PR cherry picks the commit from #62 and updates the docs, etc to
support the release to artifact hub on merge to main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants