Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental interfaces and traits for TensorNetwork-derived types #172

Merged
merged 26 commits into from
Aug 14, 2024

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Jul 23, 2024

This is a experiment to have a cleaner and more reusable interfaces between types in the TensorNetwork hierarchy of types.

To do

  •  Refactor replace!
  • Rethink about using Core.kwcall for keyword-dispatching
  • Write a post on docs about how this works internally
  • Remove calls to previous "dispatch system" (not really dispatch)
  • Fix docstrings of @kwdispatch/@kwmethod methods

Related links

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 88.39779% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (3c2861f) to head (de7c8bd).
Report is 2 commits behind head on master.

Files Patch % Lines
src/TensorNetwork.jl 89.36% 10 Missing ⚠️
src/Quantum.jl 86.95% 9 Missing ⚠️
src/Ansatz/Chain.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   67.08%   70.55%   +3.46%     
==========================================
  Files          27       27              
  Lines        1996     2000       +4     
==========================================
+ Hits         1339     1411      +72     
+ Misses        657      589      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing mofeing changed the title Experimental interfaces for TensorNetwork-derived types Experimental interfaces and traits for TensorNetwork-derived types Jul 23, 2024
@mofeing mofeing force-pushed the feature/simple-abstract-classes branch from a6b1cd8 to 2d65c78 Compare August 6, 2024 21:01
@mofeing mofeing added enhancement New feature or request refactor Change internals breaking-change labels Aug 7, 2024
@mofeing mofeing marked this pull request as ready for review August 7, 2024 21:05
@mofeing
Copy link
Member Author

mofeing commented Aug 7, 2024

It's weird that the test fails when it works in my laptop...

@Todorbsc
Copy link
Contributor

Todorbsc commented Aug 8, 2024

It's weird that the test fails when it works in my laptop...

They are working in my laptop as well. It is something about the CI that we must check but, from my side, this is ready for merge 👍

src/Quantum.jl Outdated Show resolved Hide resolved
@mofeing
Copy link
Member Author

mofeing commented Aug 9, 2024

Finally I managed to reproduce the test fails in my laptop. Still don't know why it was working before 🤷.

@Todorbsc
Copy link
Contributor

Todorbsc commented Aug 9, 2024

Finally I managed to reproduce the test fails in my laptop. Still don't know why it was working before 🤷.

What did you do to make them fail in your laptop?

@mofeing
Copy link
Member Author

mofeing commented Aug 9, 2024

Nothing really. I think it was something related to some commits or some bug in the code. Still weird.

@mofeing
Copy link
Member Author

mofeing commented Aug 9, 2024

@jofrevalles @Todorbsc @starsfordummies the only thing that bugs me is if we want all methods to be callable from subtypes; i.e. we want to be able to push!/delete! Tensors from a MPS.

@mofeing mofeing merged commit 9467998 into master Aug 14, 2024
6 checks passed
@mofeing mofeing deleted the feature/simple-abstract-classes branch August 14, 2024 13:39
@mofeing mofeing added this to the 0.8 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Change internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants