-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental interfaces and traits for TensorNetwork
-derived types
#172
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 67.08% 70.55% +3.46%
==========================================
Files 27 27
Lines 1996 2000 +4
==========================================
+ Hits 1339 1411 +72
+ Misses 657 589 -68 ☔ View full report in Codecov by Sentry. |
TensorNetwork
-derived typesTensorNetwork
-derived types
a6b1cd8
to
2d65c78
Compare
It's weird that the test fails when it works in my laptop... |
They are working in my laptop as well. It is something about the CI that we must check but, from my side, this is ready for merge 👍 |
Finally I managed to reproduce the test fails in my laptop. Still don't know why it was working before 🤷. |
What did you do to make them fail in your laptop? |
Nothing really. I think it was something related to some commits or some bug in the code. Still weird. |
@jofrevalles @Todorbsc @starsfordummies the only thing that bugs me is if we want all methods to be callable from subtypes; i.e. we want to be able to |
This is a experiment to have a cleaner and more reusable interfaces between types in the
TensorNetwork
hierarchy of types.To do
replace!
Core.kwcall
for keyword-dispatching@kwdispatch
/@kwmethod
methodsRelated links