Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion on ChainRules.rrule(contract) #296

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Jan 18, 2025

this should fix CI definitely

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.04%. Comparing base (f2abea6) to head (bf20eae).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
ext/TenetChainRulesCoreExt/rrules.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #296      +/-   ##
=========================================
- Coverage    0.04%   0.04%   -0.01%     
=========================================
  Files          32      34       +2     
  Lines        2146    2295     +149     
=========================================
  Hits            1       1              
- Misses       2145    2294     +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing
Copy link
Member Author

mofeing commented Jan 19, 2025

i took advantage and also fixed some yao tests

the CI fails currently because it fails to find the CondaPkg.toml when running ]test so no Python packages are installed

@mofeing mofeing merged commit b98cd13 into master Jan 19, 2025
5 of 7 checks passed
@mofeing mofeing deleted the fix/infinite-recursion-on-rrule-contract branch January 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant