Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: viewer: draw XYZ axes #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RFC: viewer: draw XYZ axes #103

wants to merge 1 commit into from

Conversation

strohel
Copy link
Collaborator

@strohel strohel commented Jul 23, 2023

This is extremely naive implementation, but firing it just to get going. It seems to work, but I cannot rotate or zoom in the viewer (that's a privilege that only Mac users have at the moment).

Once finalized, fixes #62.

Screenshot_20230723_181803

@strohel strohel requested a review from bschwind July 23, 2023 16:23
@bschwind
Copy link
Owner

I found an interesting approach to drawing an infinite grid, with anti-aliasing and fade-out (sometimes called fog):

https://asliceofrendering.com/scene%20helper/2020/01/05/InfiniteGrid/

We don't need anti-aliasing as we're using smaa-rs, but it might be interesting to borrow some techniques from there, especially the infinite part.

@bschwind
Copy link
Owner

Probably not an issue with your code, but there are rendering artifacts when in perspective mode. This also happens when scaling the model.

Ideally, we wouldn't scale the lines and model when zooming the camera, and that "hack" will go away once @skywhale adds his camera movement code.

Screen Shot 2023-07-24 at 11 24 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add XYZ grids
2 participants