Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Entity enums values #21

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Document Entity enums values #21

merged 2 commits into from
Oct 4, 2021

Conversation

vladimirok5959
Copy link
Contributor

Close #20

@dim dim requested a review from mxmCherry October 4, 2021 07:48
@mxmCherry
Copy link
Contributor

Most likely, both entity fields and route params could use the same 4-column table (with Values col): https://github.com/ruby-grape/grape#values

Just for param values it's safer to use param_values&.inspect (as they can be ranges etc - not just arrays).

But this can be addressed later, just don't close original issue #20

@dim dim merged commit cd319df into bsm:main Oct 4, 2021
@mxmCherry mxmCherry mentioned this pull request Oct 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmCherry mxmCherry mxmCherry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document enums
3 participants
@vladimirok5959 @mxmCherry @dim