Add more safety checks

bsq-ports · Feb 25, 2025 · 0094180 · 0094180
1 parent 8578bcb
commit 0094180
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/UI/ViewControllers/DownloadHistory.cpp b/src/UI/ViewControllers/DownloadHistory.cpp
@@ -223,11 +223,13 @@ void ViewControllers::DownloadHistoryViewController::ProcessDownloads(bool force
         currentEntry->lastUpdate = now;
 
         currentEntry->downloadProgress = downloadProgress;
-        if (currentEntry->UpdateProgressHandler != nullptr) {
-            BSML::MainThreadScheduler::Schedule([currentEntry] {
+
+        BSML::MainThreadScheduler::Schedule([currentEntry] {
+            if (currentEntry->UpdateProgressHandler != nullptr) {
                 currentEntry->UpdateProgressHandler();
-            });
-        }
+            }
+        });
+
         DEBUG("DownloadProgress: {}", downloadProgress);
     };
     DEBUG("Hash {}", currentEntry->hash);

diff --git a/src/UI/ViewControllers/DownloadHistoryCell.cpp b/src/UI/ViewControllers/DownloadHistoryCell.cpp
@@ -56,6 +56,9 @@ namespace BetterSongSearch::UI::ViewControllers {
     }
 
     void CustomDownloadListTableCell::WasPreparedForReuse() {
+        if (!entry) {
+            return;
+        }
         entry->UpdateProgressHandler = nullptr;
     }
 }  // namespace BetterSongSearch::UI::ViewControllers
diff --git a/src/UI/ViewControllers/SongList.cpp b/src/UI/ViewControllers/SongList.cpp
@@ -243,7 +243,7 @@ void ViewControllers::SongListController::SelectSong(UnityW<HMUI::TableView> tab
         return;
     }
     DEBUG("Cell clicked {}", id);
-    if (dataHolder.displayedSongList.size() <= id) {
+    if (dataHolder.displayedSongList.size() <= id || id < 0) {
         // Return if the id is invalid
         return;
     }