-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youngslohmlife/fix-usage-as-dependency #2
base: main
Are you sure you want to change the base?
youngslohmlife/fix-usage-as-dependency #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dont include this file, on diff os it might fuck up things. add it to git ignore
@@ -47,6 +47,7 @@ export class RustContract { | |||
log: this.params.log, | |||
}); | |||
|
|||
console.log([this._id, this.params.address, this.params.bytecode, this.params.gasLimit, this.params.network]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
@@ -97,7 +97,7 @@ export class Assertion { | |||
} | |||
let threw: Error | undefined; | |||
try { | |||
await this.actual(); | |||
await (this.actual as () => Promise<void>)(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arent you able to change the type of this.actual instead?
Fixes to package to make it usable as an ESM module when imported from another package that depends on a test harness for OP_NET.