-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet+chain: add new APIs GetPeerInfo
, GetBlockChainInfo
, and RawRequest
to chain interface
#973
base: master
Are you sure you want to change the base?
wallet+chain: add new APIs GetPeerInfo
, GetBlockChainInfo
, and RawRequest
to chain interface
#973
Conversation
GetPeerInfo
, GetBlockChainInfo
, and RawRequest
to chain interfaceGetPeerInfo
, GetBlockChainInfo
, and RawRequest
to chain interface
Approved CI. |
1d91cdd
to
8a4f7c9
Compare
In this commit, we add new APIs to chain interface used across `btcd`, `neutrino`, and `bitcoind` chain backends. The new APIs are `GetPeerInfo`, `GetBlockChainInfo`, and `RawRequest`. The motivation behind adding those APIs is to easier the process of unifying RPC connection creations across chain backends as part of LND Daemon.
In this commit, we decouple `BitcoindClient.GetBlockHeight` method from btcd library by making it utilize `BitcoindClient.GetBlockHeaderVerbose` instead.
8a4f7c9
to
96f4d5a
Compare
It looks like approval is required whenever an updated commit is submitted. Additionally, it doesn’t seem to be configured to trigger against the master branch in the forked repository. I'm also unsure about the linting process when running
EDIT: |
Usually in other projects we're able to specifying a starting commit in the linter. It only attempts to flag linting errors of new changes after that commit. Looks like we're missing that config here. So I think we should either add that starting commit (here's an example for lnd), or we can move forward wit hthis PR, verifying that no new linter violations are hit. |
Description
In this commit, we add new APIs to chain interface used across
btcd
,neutrino
, andbitcoind
chain backends. The new APIs areGetPeerInfo
,GetBlockChainInfo
, andRawRequest
.Addresses part of lightningnetwork/lnd#7951.
Dependent PR lightningnetwork/lnd#9435.
Motivation and Context
The motivation behind adding those APIs is to easier the process of unifying RPC connection creations across chain backends as part of LND Daemon.