Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/355 wp5.8 collapsible block generated anchors issues #364

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Bug/355 wp5.8 collapsible block generated anchors issues #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2d727a3
initial prototype
acketon Aug 25, 2023
4f8adf0
cleanup
acketon Aug 25, 2023
1ad69b3
update
acketon Aug 25, 2023
f93b8e6
remove test code
acketon Aug 25, 2023
750a5f5
rename
acketon Aug 25, 2023
16de4f1
fix bug in param name
acketon Aug 25, 2023
48e563a
Merge branch 'feature/wp-scripts-restructure' into bug/355-wp5.8-coll…
acketon Jun 7, 2024
452bea5
use span for richtext component in editor to fix bug where you can’t …
acketon Jun 7, 2024
f76e524
fix bug where autoID is not generated if user turns toggle on but doe…
acketon Jun 7, 2024
f6a908c
rebuild
acketon Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/blocks.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('react'), 'version' => '44f9dcda4cfcbf76e6c5');
<?php return array('dependencies' => array('react'), 'version' => 'cf7c07081ea2c5ccd56c');
2 changes: 1 addition & 1 deletion dist/blocks.css.map
View file
Open in desktop

Large diffs are not rendered by default.

214 changes: 193 additions & 21 deletions dist/blocks.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/blocks.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/style-blocks.css.map
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 12 additions & 10 deletions src/blocks/collapsible-control/collapsible-control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,18 @@ registerBlockType( 'bu/collapsible-control', {

<Fragment>
<p {...blockProps}>
<RichText
tagName="button"
className={togglebuttonclasses}
placeholder={ __( 'Toggle Text' ) }
value={ text }
onChange={ ( value ) => setAttributes( { text: value } ) }
formattingControls={ [ 'bold', 'italic' ] }
withoutInteractiveFormatting
keepPlaceholderOnFocus
/>
<button>
<RichText
tagName="span"
className={togglebuttonclasses}
placeholder={ __( 'Toggle Text' ) }
value={ text }
onChange={ ( value ) => setAttributes( { text: value } ) }
formattingControls={ [ 'bold', 'italic' ] }
withoutInteractiveFormatting
keepPlaceholderOnFocus
/>
</button>
</p>
<InspectorControls>
<PanelBody title={ __( 'Control Options' ) }>
Expand Down
Loading