Merge pull request #58 from bu-ist/hotfix/jquery-edit-props

Fix jQuery compatibility
bu-ist · Aug 31, 2020 · d6f6e18 · d6f6e18
2 parents 4676a05 + d90ea9d
commit d6f6e18
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/bu-navigation.php b/bu-navigation.php
@@ -5,7 +5,7 @@
 Author: Boston University (IS&T)
 Author URI: http://sites.bu.edu/web/
 Description: Provides alternative navigation elements designed for blogs with large page counts
-Version: 1.2.19
+Version: 1.2.20
 Text Domain: bu-navigation
 Domain Path: /languages
 */
@@ -60,7 +60,7 @@ class BU_Navigation_Plugin {
 	// Plugin settings
 	public $settings;
 
-	const VERSION = '1.2.19';
+	const VERSION = '1.2.20';
 
 	public function __construct() {
 

diff --git a/js/manage.js b/js/manage.js
@@ -337,13 +337,13 @@ if ((typeof bu === 'undefined') ||
 
 		edit: function (link) {
 
-			$(this.ui.urlField).attr("value", link.post_content);
-			$(this.ui.labelField).attr("value", link.post_title);
+			$(this.ui.urlField).prop("value", link.post_content);
+			$(this.ui.labelField).prop("value", link.post_title);
 
 			if ('new' === link.post_meta.bu_link_target) {
-				$(this.ui.targetNewField).attr("checked", "checked");
+				$(this.ui.targetNewField).prop("checked", true);
 			} else {
-				$(this.ui.targetSameField).attr("checked", "checked");
+				$(this.ui.targetSameField).prop("checked", true);
 			}
 
 			this.data.currentLink = link;
@@ -361,10 +361,10 @@ if ((typeof bu === 'undefined') ||
 				var link = this.data.currentLink, saved, selected;
 
 				// Extract updates from form
-				link.post_content = $(this.ui.urlField).attr("value");
-				link.post_title = $(this.ui.labelField).attr("value");
+				link.post_content = $(this.ui.urlField).prop("value");
+				link.post_title = $(this.ui.labelField).prop("value");
 				link.url = link.post_content;
-				link.post_meta.bu_link_target = $("input[name='editlink_target']:checked").attr("value");
+				link.post_meta.bu_link_target = $("input[name='editlink_target']:checked").prop("value");
 
 				selected = Navtree.getSelectedPost();
 

diff --git a/js/manage.min.js b/js/manage.min.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bu-navigation",
-  "version": "1.2.19",
+  "version": "1.2.20",
   "description": "Provides alternative navigation elements designed for blogs with large page counts",
   "main": "bu-navigation.php",
   "directories": {

diff --git a/readme.md b/readme.md
@@ -3,7 +3,7 @@
 **Tags:** navigation, hierarchical, post type, boston university, bu  
 **Requires at least:** 3.1  
 **Tested up to:** 5.5
-**Stable tag:** 1.2.19  
+**Stable tag:** 1.2.20
 **License:** GPLv2 or later  
 **License URI:** http://www.gnu.org/licenses/gpl-2.0.html  
 

diff --git a/readme.txt b/readme.txt
@@ -3,7 +3,7 @@ Contributors: ntk, mgburns, gcorne, jtwiest, awbauer, inderpreet99
 Tags: navigation, hierarchical, post type, boston university, bu
 Requires at least: 3.1
 Tested up to: 5.5
-Stable tag: 1.2.19
+Stable tag: 1.2.20
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html