Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix critical PHPCS issues #49

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fix critical PHPCS issues #49

wants to merge 16 commits into from

Conversation

philcable
Copy link

@philcable philcable commented Nov 27, 2019 •
edited
Loading

For 5.x upgrade preparation:

  • Fix unprepared SQL queries
  • Consolidate SQL query code to avoid false positives for unprepared statement
  • Replace local wp_redirect() calls with wp_safe_redirect()
  • Update post type name in order test to avoid use of reserved order post type

philcable and others added 16 commits November 20, 2019 07:44
@philcable
Add PHPCS configuration file
a02063f
@philcable
Consolidate SQL query to avoid false positive for unprepared statement
e77f7de
@philcable
Use a placeholder instead of interpolating $post->post_type
9f8be72 
This also consolidates the statement to avoid a false positive for
an unprepared SQL statement.
@philcable
Use a placeholder instead of interpolating BU_NAVIGATION_LINK_POST_TYPE
62aaab7 
This also consolidates the statement to avoid a false positive for
an unprepared SQL statement.
@philcable
Fix unprepared SQL statment
dad296a 
This also flags the false positive below the updated statement.
@philcable
Fix unprepared SQL statment
3d5f273 
This also flags the false positive below the updated statement.
@philcable
Fix unprepared SQL statment
8873cbc 
This also flags the false positive below the updated statement.
@philcable
Fix unprepared SQL statment
f298bb7 
This also flags the false positive below the updated statement.
@philcable
Consolidate SQL query to avoid false positive for unprepared statement
891ddd2
@philcable
Fix unprepared SQL statement
5342138
@philcable
Fix unprepared SQL statement
fb80364 
This also consolidates the query to avoid a false positive for
an unprepared SQL statement.
@philcable
Use wp_safe_redirect() instead of wp_redirect()
01bfa69 
This also follows the redirect with a call to `exit;`
@philcable
Improve prepared queries
c9aea74
@philcable
Fix unprepared SQL query in bu_navigation_get_posts() function
56c47d4 
The `$fields` variable probably needs some updated handling, too.
@philcable
Update test to avoid use of reserved post type order
4908f09 
Not certain how necessary this change really is, as this is a test.
@jeremyfelt
Pass filtered $field array through esc_sql() before using
b327444 
This is likely safe already, but it doesn't hurt to check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyfelt jeremyfelt jeremyfelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philcable @jeremyfelt