Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search template to Responsive Framework #274

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ashleykolodziej
Copy link
Contributor

@ashleykolodziej ashleykolodziej commented Jul 30, 2021

Please do not merge... yet! Fixes #114 once it gets a little more love.

This is now actually functional! However, it only searches bu.edu/researchsupport right now, because we can't just use the site URL like the original code wanted - sandboxes aren't indexed by Google, which means this will always return 0 results.

Ideally, we should be able to do something like override this from the wordpress admin on a sandbox site.

Working example at https://id-ashley.cms-devl.bu.edu/search-branch/search/?q=animal%20care&pg=1

@hirozed
Copy link
Contributor

hirozed commented Jul 30, 2021

@ashleykolodziej This is the error killing the search page:
[30-Jul-2021 15:25:57 America/New_York] PHP Fatal error: Uncaught Error: Call to undefined function responsive_content_banner() in /var/www/sandboxes/id-jim/archives/2021-07-27-142851-cms-1627396738/wp-content/themes/responsive-framework-2-x/searchpage.php:9

For some really odd reason, it can't find responsive_content_banner even though it does exist in the theme.

Would there be harm in removing the call to responsive_content_banner? It's not like anyone can add a banner (an old one at that) to a search page.

@ashleykolodziej
Copy link
Contributor Author

@hirozed no harm at all, I'd rather see if we can get something working now. Let's worry about banners later. Go for it!

@ashleykolodziej ashleykolodziej changed the title Migrating Fyodor's work on search results template to 2x Add a search template to Responsive Framework Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a search page template
2 participants