Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Midend]use declarative-pass-specification. #282

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Midend]use declarative-pass-specification. #282

wants to merge 3 commits into from

Conversation

linuxlonelyeagle
Copy link
Member

No description provided.

@linuxlonelyeagle linuxlonelyeagle force-pushed the use-declarative-pass-specification branch from 68f6174 to 9257e64 Compare January 30, 2024 16:11
@linuxlonelyeagle
Copy link
Member Author

@zhanghb97 If something is wrong, feel free to modify it.

@linuxlonelyeagle
Copy link
Member Author

I seem to have found a new problem, should we adjust the namespace of register,for example mlir::buddy::registerMatMulOptimizePass(), should we adjust it to buddy::registerMatMulOptimizePass()? I'm not quite sure, because our own dialect is actually defined directly in buddy's namespace, and this implies that the item buddy is on the same level as mlir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanghb97 zhanghb97 zhanghb97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuxlonelyeagle @zhanghb97