-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Midend] Enhancements and Optimizations for batch matmul and convolution [Examples] Added MLIRLinalg Examples for Various Optimization Options. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion [Examples] Added MLIRLinalg Examples for Various Optimization Options. fixed thirdparty.
xlinsist
reviewed
Oct 11, 2024
xlinsist
reviewed
Oct 11, 2024
xlinsist
reviewed
Oct 11, 2024
xlinsist
reviewed
Oct 11, 2024
xlinsist
reviewed
Oct 11, 2024
You can copy the description from the former PR(#384) into this one. |
xlinsist
reviewed
Oct 12, 2024
Comment on lines
+5
to
+7
BatchMatMulOptimize.cpp | ||
BatchMatMulTileOptimize.cpp | ||
BatchMatMulSCFOptimize.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our optimized methods need to add into both MatMulOptimization
and BatchMatMulOptimization
?
LGTM, thanks! |
…ion [Examples] Added MLIRLinalg Examples for Various Optimization Options.
…ion [Examples] Added MLIRLinalg Examples for Various Optimization Options.
…ion. example check implement.
…. Fixed FILECHECK bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Midend] Enhancements and Optimizations
BatchMatMul:
Conv2D NHWC-FHWC:
Depthwise Conv2D NHWC-HWC:
[Examples] Added MLIRLinalg Examples for Various Optimization Options
New MLIRLinalg examples were added to demonstrate the usage of new buddy-opt various optimization options , including:
vectorization layout optimization.
Example MLIR Files:
batchmatmul
conv2d_nhwc_fhwc
depthwise_conv_2d_nhwc_hwc
These updates collectively improve the performance of matrix and convolution operations in MLIR, providing optimized patterns for common workloads like BatchMatMul and convolution layers.