Skip to content

Commit

Permalink
lints
Browse files Browse the repository at this point in the history
  • Loading branch information
unmultimedio committed Feb 29, 2024
1 parent ff69892 commit 08c10ea
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func newTestModuleReader(moduleIdentityStringToModule map[string]bufmodule.Modul
}
}

func (r *testModuleReader) GetModule(ctx context.Context, modulePin bufmoduleref.ModulePin) (bufmodule.Module, error) {
func (r *testModuleReader) GetModule(_ context.Context, modulePin bufmoduleref.ModulePin) (bufmodule.Module, error) {
module, ok := r.moduleIdentityStringToModule[modulePin.IdentityString()]
if !ok {
return nil, &fs.PathError{Op: "read", Path: modulePin.String(), Err: fs.ErrNotExist}
Expand Down
3 changes: 0 additions & 3 deletions private/bufpkg/bufmodule/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ func newModuleForProto(
}
}
return newModule(
ctx,
readWriteBucket,
allDependenciesRefs, // Since proto has no distinction between direct/transitive dependencies, we'll need to set them all as direct, otherwise the build will fail.
dependencyModulePins,
Expand Down Expand Up @@ -183,7 +182,6 @@ func newModuleForBucket(
moduleIdentity = moduleConfig.ModuleIdentity
}
return newModule(
ctx,
storage.MapReadBucket(sourceReadBucket, storage.MatchPathExt(".proto")),
moduleConfig.Build.DependencyModuleReferences, // straight copy from the buf.yaml file
dependencyModulePins,
Expand Down Expand Up @@ -220,7 +218,6 @@ func newModuleForFileSet(

// this should only be called by other newModule constructors
func newModule(
ctx context.Context,
// must only contain .proto files
sourceReadBucket storage.ReadBucket,
declaredDirectDependencies []bufmoduleref.ModuleReference,
Expand Down

0 comments on commit 08c10ea

Please sign in to comment.