Fix flaky symlink test on windows (#3332)

bufbuild · Sep 20, 2024 · 7a0cfd1 · 7a0cfd1
1 parent cea42e6
commit 7a0cfd1
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/private/pkg/storage/storageos/storageos_test.go b/private/pkg/storage/storageos/storageos_test.go
@@ -85,17 +85,13 @@ func TestOS(t *testing.T) {
 		require.NoError(t, err)
 		tempDir = filepath.Join(tempDir, "sym")
 		require.NoError(t, os.Symlink(actualTempDir, tempDir))
-		t.Cleanup(func() {
-			if err := os.Remove(tempDir); err != nil {
-				t.Error(err)
-			}
-		})
 		provider := storageos.NewProvider(storageos.ProviderWithSymlinks())
 		bucket, err := provider.NewReadWriteBucket(tempDir, storageos.ReadWriteBucketWithSymlinksIfSupported())
 		require.NoError(t, err)
 
-		_, err = bucket.Get(ctx, "foo.txt")
+		foo, err := bucket.Get(ctx, "foo.txt")
 		require.NoError(t, err)
+		require.NoError(t, foo.Close())
 
 		// Try reading a file as if foo.txt is a directory.
 		_, err = bucket.Get(ctx, "foo.txt/bar.txt")