Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port buf to use protoplugin #2820

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Port buf to use protoplugin #2820

merged 11 commits into from
Mar 19, 2024

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Mar 18, 2024

No description provided.

@bufdev bufdev requested a review from mfridman March 18, 2024 15:59
Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to have this logic consolidated in one place.

did we need to address the TODO re. source-retention options in the protoc exec?

@bufdev
Copy link
Member Author

bufdev commented Mar 18, 2024

Yes we do, caught up with @jhump offline and I have a path forward, will do some testing later

@bufdev
Copy link
Member Author

bufdev commented Mar 19, 2024

Merging so we can test with this today, will follow up

@bufdev bufdev merged commit c87a7d3 into bufmod Mar 19, 2024
8 checks passed
@bufdev bufdev deleted the bufmod-protoplugin branch March 19, 2024 13:33
@bufdev
Copy link
Member Author

bufdev commented Mar 19, 2024

Verified with @jhump that source-retention options are propagated to protoc as we expect, we did manual QA (this would be incredibly hard to add an automated test for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants