-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port buf to use protoplugin #2820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to have this logic consolidated in one place.
did we need to address the TODO re. source-retention options in the protoc exec?
Yes we do, caught up with @jhump offline and I have a path forward, will do some testing later |
Merging so we can test with this today, will follow up |
Verified with @jhump that source-retention options are propagated to |
No description provided.