Force usage of private/pkg/protoencoding #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
approved these changes
Sep 26, 2024
doriable
approved these changes
Sep 26, 2024
jhump
reviewed
Sep 26, 2024
| - '^protojson.Marshal$' | ||
| - '^protojson.Unmarshal$' | ||
| - '^protojson.MarshalOptions$' | ||
| - '^protojson.UnmarshalOptions$' |
There was a problem hiding this comment.
Ugh probably - @emcfarlane any chance you can commandeer and add?
jhump
approved these changes
Sep 26, 2024
|
Actually @emcfarlane just going to merge this as-is, can you add protoyaml as a follow-up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably should have been done a long time ago. This forces usage of
private/pkg/protoencodingso that we don't keep on getting marshal/unmarshal problems, and stay consistent. A follow-up should do this in core as well.